Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actions] Rename tls.* configs to ssl.* #102902

Merged
merged 4 commits into from
Jun 23, 2021
Merged

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Jun 22, 2021

Resolves #101916

Summary

This PR renames the tls.* actions config options introduced in 7.14 to ssl.* in order to standardize the naming of this config key across all stack components.

Affected configs:

  • xpack.actions.ssl.verificationMode - introduced in this PR
  • xpack.actions.ssl.proxyVerificationMode - introduced in this PR
  • xpack.actions.customHostSettings.ssl.* - introduced in this PR

Checklist

Delete any items that are not applicable to this PR.

@ymao1 ymao1 changed the title Changing tls to ssl [Actions] Rename tls.* configs to ssl.* Jun 22, 2021
@ymao1 ymao1 self-assigned this Jun 22, 2021
@ymao1 ymao1 added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.14.0 v8.0.0 labels Jun 22, 2021
@ymao1 ymao1 marked this pull request as ready for review June 22, 2021 15:41
@ymao1 ymao1 requested review from a team as code owners June 22, 2021 15:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@ymao1 ymao1 requested a review from pmuellr June 22, 2021 15:41
@ymao1 ymao1 requested a review from jbudz June 22, 2021 15:59
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested it just enough to see that the new config properties are getting picked up - I'm confident that the jest and functional tests test this enough.

@ymao1 ymao1 requested a review from legrego June 22, 2021 20:02
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much for taking this on!

@chrisronline chrisronline self-requested a review June 23, 2021 15:18
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ymao1
Copy link
Contributor Author

ymao1 commented Jun 23, 2021

@elasticmachine merge upstream

@ymao1 ymao1 added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 23, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@ymao1 ymao1 merged commit 874dfc6 into elastic:master Jun 23, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 23, 2021
* Changing tls to ssl

* Changing tls to ssl

* Updating docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 23, 2021
* Changing tls to ssl

* Changing tls to ssl

* Updating docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: ymao1 <ying.mao@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Actions] Change config path for xpack.actions.customHostSettings from the .tls. config key portion to .ssl.
7 participants